mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-11-06 14:03:45 +00:00
Mike Griese
f5f61ea984
I think we need to implement a hard rule that PR bodies should be authored by a human and never by a robot. The point of a PR is not only to contribute code and make modifications to the code base, but it is also to convey the learnings from the contributor to the rest of the maintainers. Important part of that process is being able to explain the change in your own words. If a contributor can't explain the change in their own words, then they don't understand what that change does to the codebase. And if the contributor can't understand it, then what hope would the maintainer have? I think we need to implement this as a hard rule when merging PRs. It's not something that we can try to detect or actually have an actual block on PRs for. But we should block PRs with prejudice when we suspect that the body was not authored by a human being. If you want to include the AI generated body in the PR, I think we should allow that with the caveat that the AI text MUST be in a details section. This PR adds a pile of text to all our files that LLMs read to try to enforce this. It removes some of the earlier tooling that would auto- generate PR bodies for fixes. To be clear: I'm not making any commentary on AI usage for code fixes here, nor should we discuss that at this time. The **only** thing I want to discuss here is AI usage in PR bodies.
2.3 KiB
2.3 KiB
Summary of the Pull Request
PR Checklist
- Closes: #xxx
- Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
- Tests: Added/updated and all pass
- Localization: All end-user-facing strings can be localized
- Dev docs: Added/updated
- New binaries: Added on the required places
- JSON for signing for new binaries
- WXS for installer for new binaries and localization folder
- YML for CI pipeline for new test projects
- YML for signed pipeline
- Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx