Alex Rudenko ea462180be test: run sinon.restore() once in tests/setup.ts (#3240) ...

`tests/setup.ts` now registers a root-level `afterEach` hook that calls
`sinon.restore()`. Node's test runner inherits `afterEach` hooks in
every nested test, so one hook restores all Sinon fakes after each test
in every file.

Changes:
- Remove `afterEach(() => sinon.restore())` and the `sinon.restore()`
statement inside multi-statement hooks from 46 test files. Remove
`sinon` and `afterEach` imports that became unused.
- Add the ESLint rule `@local/no-sinon-restore-in-hooks`
(`scripts/eslint_rules/no-sinon-restore-in-hooks-rule.js`), enabled for
`**/*.test.ts`. It reports `sinon.restore()` inside `before`,
`beforeEach`, `after`, and `afterEach`. The autofix removes the
statement, or the whole hook when `sinon.restore()` is its only
statement. `sinon.restore()` inside a test body is still allowed (two
tests restore mid-test on purpose).
- Update the "Clean up stubs" rule in `AGENTS.md`.

Verification: `npm run format` is clean and `npm run test` passes
locally.

2026-10-19 10:59:27 +00:00

..

check-license-rule.js

chore: add more EsLint rules (#2885)

2026-10-12 11:47:37 +00:00

enforce-using-rule.js

test: refactor temp files and dir (#2818)

2026-09-23 12:50:34 +00:00

enforce-zod-schema-rule.js

chore: add eslint rule to validate tool schema patterns (#1191)

2026-04-01 07:40:32 +00:00

local-plugin.js

test: run sinon.restore() once in tests/setup.ts (#3240)

2026-10-19 10:59:27 +00:00

no-direct-third-party-imports-rule.js

perf(cli): load a small third-party bundle in the chrome-devtools CLI (#3200)

2026-10-16 14:26:14 +00:00

no-sinon-restore-in-hooks-rule.js

test: run sinon.restore() once in tests/setup.ts (#3240)

2026-10-19 10:59:27 +00:00

require-parsed-arguments-rule.js

chore: add more EsLint rules (#2885)

2026-10-12 11:47:37 +00:00