mirror of
https://github.com/coollabsio/coolify.git
synced 2026-11-04 10:42:23 +00:00
Andras Bacsai
99c840922c
High disk usage notifications were sent every ~10 minutes on Coolify Cloud because the cache rate limiter did not hold across Sentinel-triggered checks. - Add a notification_throttles table and NotificationThrottle helper that atomically records when a notification was sent for a resource. - Add the ThrottledNotification contract; Team::notify() skips a throttled notification that was already sent within its interval. - High disk usage: configurable per-server interval (server_disk_usage_notification_interval_hours, default 24h) in Server > Advanced and the servers API. - Container restarted (coolify-proxy, database TCP proxy): at most one notification per hour per server/database during a restart loop. - Move the unreachable and missing-backup markers into the new table and migrate existing data (servers.unreachable_notification_sent and scheduled_database_backups.missing_backup_notification_sent_at). - Regenerate OpenAPI files.
101 lines
3.1 KiB
PHP
101 lines
3.1 KiB
PHP
<?php
|
|
|
|
use App\Models\NotificationThrottle;
|
|
use App\Models\Server;
|
|
use App\Models\Team;
|
|
use App\Notifications\Server\Unreachable;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('disables (non-destructively) self-hosted servers with unreachable_count >= 3 after 7 days', function () {
|
|
config(['constants.coolify.self_hosted' => true]);
|
|
|
|
$team = Team::factory()->create();
|
|
$server = Server::factory()->create([
|
|
'team_id' => $team->id,
|
|
'unreachable_count' => 50,
|
|
'updated_at' => now()->subDays(8),
|
|
]);
|
|
NotificationThrottle::record($server, Unreachable::class);
|
|
|
|
$originalIp = (string) $server->ip;
|
|
|
|
$this->artisan('cleanup:unreachable-servers')->assertSuccessful();
|
|
|
|
$server->refresh();
|
|
// IP must be preserved — never overwritten on self-hosted.
|
|
expect($server->ip)->toBe($originalIp);
|
|
expect($server->settings->force_disabled)->toBeTrue();
|
|
});
|
|
|
|
it('overwrites the IP with 1.2.3.4 on cloud for servers with unreachable_count >= 3 after 7 days', function () {
|
|
config(['constants.coolify.self_hosted' => false]);
|
|
|
|
$team = Team::factory()->create();
|
|
$server = Server::factory()->create([
|
|
'team_id' => $team->id,
|
|
'unreachable_count' => 50,
|
|
'updated_at' => now()->subDays(8),
|
|
]);
|
|
NotificationThrottle::record($server, Unreachable::class);
|
|
|
|
$this->artisan('cleanup:unreachable-servers')->assertSuccessful();
|
|
|
|
$server->refresh();
|
|
expect($server->ip)->toBe('1.2.3.4');
|
|
});
|
|
|
|
it('does not clean up servers with unreachable_count less than 3', function () {
|
|
$team = Team::factory()->create();
|
|
$server = Server::factory()->create([
|
|
'team_id' => $team->id,
|
|
'unreachable_count' => 2,
|
|
'updated_at' => now()->subDays(8),
|
|
]);
|
|
NotificationThrottle::record($server, Unreachable::class);
|
|
|
|
$originalIp = (string) $server->ip;
|
|
|
|
$this->artisan('cleanup:unreachable-servers')->assertSuccessful();
|
|
|
|
$server->refresh();
|
|
expect($server->ip)->toBe($originalIp);
|
|
expect($server->settings->force_disabled)->toBeFalse();
|
|
});
|
|
|
|
it('does not clean up servers updated within 7 days', function () {
|
|
$team = Team::factory()->create();
|
|
$server = Server::factory()->create([
|
|
'team_id' => $team->id,
|
|
'unreachable_count' => 10,
|
|
'updated_at' => now()->subDays(3),
|
|
]);
|
|
NotificationThrottle::record($server, Unreachable::class);
|
|
|
|
$originalIp = (string) $server->ip;
|
|
|
|
$this->artisan('cleanup:unreachable-servers')->assertSuccessful();
|
|
|
|
$server->refresh();
|
|
expect($server->ip)->toBe($originalIp);
|
|
expect($server->settings->force_disabled)->toBeFalse();
|
|
});
|
|
|
|
it('does not clean up servers without notification sent', function () {
|
|
$team = Team::factory()->create();
|
|
$server = Server::factory()->create([
|
|
'team_id' => $team->id,
|
|
'unreachable_count' => 10,
|
|
'updated_at' => now()->subDays(8),
|
|
]);
|
|
|
|
$originalIp = (string) $server->ip;
|
|
|
|
$this->artisan('cleanup:unreachable-servers')->assertSuccessful();
|
|
|
|
$server->refresh();
|
|
expect($server->ip)->toBe($originalIp);
|
|
expect($server->settings->force_disabled)->toBeFalse();
|
|
});
|