Files
coolify/app/Actions/Service/StartService.php
T
Andras BacsaiandClaude Opus 5.5 780d67ccbb fix(storage): stop a deleted volume from coming back after a redeploy
Docker Compose gives a recreated container the old mount at each path
that the image declares with VOLUME, also a volume deleted in Coolify.
Before `up`, remove only containers that still mount a Coolify volume
whose storage entry was deleted. The stale volume delete dialog now
warns when a container still uses the volume.

Closes #6875

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 22:01:54 +01:00

219 lines
11 KiB
PHP

<?php
namespace App\Actions\Service;
use App\Actions\Shared\EnsureContentFilesOnServer;
use App\Events\ServiceStartFinished;
use App\Jobs\NotifyResourceStoppedJob;
use App\Jobs\ServerFilesFromServerJob;
use App\Models\LocalFileVolume;
use App\Models\LocalPersistentVolume;
use App\Models\Service;
use App\Models\ServiceApplication;
use App\Models\ServiceDatabase;
use Illuminate\Support\Collection;
use Illuminate\Support\Facades\Log;
use Lorisleiva\Actions\Concerns\AsAction;
use Lorisleiva\Actions\Decorators\JobDecorator;
class StartService
{
use AsAction;
public function configureJob(JobDecorator $job): void
{
$job->onQueue(deployment_queue());
}
public function handle(Service $service, bool $pullLatestImages = false, bool $stopBeforeStart = false)
{
$service->parse();
self::queueFileStorageSync($service);
// Fetch remote secrets before stopping: if the secret manager fails, the service keeps running.
// saveComposeConfigs() below reuses the fetched secrets.
$service->ensureRemoteSecretsResolvable($service->environment_variables()->get());
// Compose recreates the containers, so a status check can find them stopped for a moment.
$service->applications()->get()->concat($service->databases()->get())
->each(fn (ServiceApplication|ServiceDatabase $part) => NotifyResourceStoppedJob::expectStop($part));
if ($this->shouldStopBeforeStarting($pullLatestImages, $stopBeforeStart)) {
StopService::run(service: $service, dockerCleanup: false);
}
$service->saveComposeConfigs();
$service->isConfigurationChanged(save: true);
$service->applications()->get()->each->resetRestartLimit();
$workdir = $service->workdir();
// $commands[] = "cd {$workdir}";
$commands[] = "echo 'Saved configuration files to {$workdir}.'";
// Ensure .env exists in the correct directory before docker compose tries to load it
// This is defensive programming - saveComposeConfigs() already creates it,
// but we guarantee it here in case of any edge cases or manual deployments
$commands[] = "touch {$workdir}/.env";
$commands = array_merge($commands, EnsureContentFilesOnServer::echoCommands($this->contentFileStorages($service), $service->server));
$commands = array_merge($commands, self::composeVolumeWarningCommands($service));
// The script reaches the server on stdin. Compose prompts (for example "Volume ... exists but
// doesn't match configuration. Recreate?") would read the next script lines as the answer.
// Give Compose no stdin so it uses the default answer (keep the volume). Never pass --yes:
// it recreates the volume and deletes its data.
// Pass -f so Compose uses only the file that Coolify wrote.
$compose = serverDockerConfigPrefix($service->server)."docker compose --project-directory {$workdir} -f {$workdir}/docker-compose.yml --project-name {$service->uuid}";
if ($pullLatestImages) {
$commands[] = "echo 'Pulling images.'";
$commands[] = "{$compose} pull < /dev/null";
}
if ($service->networks()->count() > 0) {
$commands[] = "echo 'Creating Docker network.'";
$commands[] = "docker network inspect $service->uuid >/dev/null 2>&1 || docker network create --attachable $service->uuid";
}
$commands = array_merge($commands, self::removeContainersWithRemovedVolumesCommands($service));
$commands[] = 'echo Starting service.';
if (data_get($service, 'connect_to_docker_network')) {
// Connect the created containers to the predefined network before they start. A container
// that needs this network during a service_healthy wait never gets it after `up -d`.
$commands[] = "{$compose} up -d --remove-orphans --force-recreate --build --no-start < /dev/null";
$composeServices = data_get(parseDockerComposeYaml(data_get($service, 'docker_compose', '')), 'services', []);
foreach ($composeServices as $serviceName => $serviceConfig) {
if ($command = self::predefinedNetworkConnectCommand($service, $serviceName, $serviceConfig)) {
$commands[] = $command;
}
}
$commands[] = "{$compose} start < /dev/null";
} else {
$commands[] = "{$compose} up -d --remove-orphans --force-recreate --build < /dev/null";
}
$commands[] = "docker network connect $service->uuid coolify-proxy >/dev/null 2>&1 || true";
$commands = array_merge($commands, $this->logDrainNetworkConnectCommands($service));
if ($service->is_maintenance_enabled) {
// Domains can change with the compose file, so the maintenance routes follow them.
try {
$service->syncMaintenancePage();
} catch (\Throwable $e) {
Log::warning('Maintenance page update failed while starting service.', ['service_uuid' => $service->uuid, 'error' => $e->getMessage()]);
}
}
return remote_process($commands, $service->server, type_uuid: $service->uuid, callEventOnFinish: 'ServiceStartFinished', callEventData: ServiceStartFinished::dataFor($service), queue: deployment_queue());
}
/**
* Connects a container to the predefined network of the destination, unless it is already
* connected (declared in the compose file, or a running container that was not recreated).
* Containers with a network_mode cannot join other networks and are skipped.
*/
public static function predefinedNetworkConnectCommand(Service $service, string $serviceName, mixed $serviceConfig): ?string
{
if (data_get($serviceConfig, 'network_mode') !== null) {
return null;
}
$network = escapeshellarg($service->destination->network);
$containerName = escapeshellarg("{$serviceName}-{$service->uuid}");
$warning = escapeshellarg("Warning: Could not connect {$serviceName} to the {$service->destination->network} network.");
$connectedNetworks = "docker container inspect --format '{{range \$name, \$_ := .NetworkSettings.Networks}}{{println \$name}}{{end}}' {$containerName}";
return "{$connectedNetworks} | grep -qxF {$network} || docker network connect --alias {$containerName} {$network} {$containerName} || echo {$warning}";
}
/**
* Removes the containers that `docker compose up` would give a volume that the user deleted
* in Coolify (see composeContainersWithRemovedVolumes()).
*
* @param string|null $composeServiceName only this Compose service, when `up` starts only it
* @return list<string>
*/
public static function removeContainersWithRemovedVolumesCommands(Service $service, ?string $composeServiceName = null): array
{
$server = $service->server;
$projectMounts = (string) instant_remote_process([composeProjectMountsCommand($service->uuid)], $server, false, maxAttempts: 1);
if (trim($projectMounts) === '') {
return [];
}
$services = data_get(parseDockerComposeYaml((string) $service->docker_compose), 'services');
$services = is_array($services) ? $services : [];
if ($composeServiceName !== null) {
$services = array_intersect_key($services, [$composeServiceName => true]);
}
$storageNames = LocalPersistentVolume::query()
->where(fn ($query) => $query->where('resource_type', (new ServiceApplication)->getMorphClass())->whereIn('resource_id', $service->applications()->select('id')))
->orWhere(fn ($query) => $query->where('resource_type', (new ServiceDatabase)->getMorphClass())->whereIn('resource_id', $service->databases()->select('id')))
->pluck('name')
->all();
$commands = [];
foreach (composeContainersWithRemovedVolumes($projectMounts, $services, $service->uuid, $storageNames) as $containerName => $volumeName) {
$commands[] = 'echo '.escapeshellarg("Removing container {$containerName}, so that it does not keep the deleted volume {$volumeName}.");
// Without --time, Docker waits the stop_grace_period of the Compose file, as Compose does.
$commands[] = 'docker stop '.escapeshellarg($containerName).' || true';
$commands[] = dockerRemoveCommand($containerName);
}
return $commands;
}
/**
* Queues one sync of the file storages with the server for each resource of the service that has
* file storages. The sync marks each storage as a file or a directory, as it is on the server.
*/
public static function queueFileStorageSync(Service $service): void
{
$service->applications()->get()
->concat($service->databases()->get())
->filter(fn (ServiceApplication|ServiceDatabase $resource): bool => $resource->fileStorages()->exists())
->each(fn (ServiceApplication|ServiceDatabase $resource) => ServerFilesFromServerJob::dispatch($resource));
}
/**
* Shows the volume warnings of the last parse (for example an external volume that the
* service does not use yet) in the start log.
*
* @return list<string>
*/
public static function composeVolumeWarningCommands(Service $service): array
{
return array_map(
fn (string $warning): string => 'echo '.escapeshellarg("Warning: {$warning}"),
$service->composeVolumeWarnings()
);
}
/**
* @return Collection<int, LocalFileVolume>
*/
private function contentFileStorages(Service $service): Collection
{
return LocalFileVolume::query()
->where(function ($query) use ($service) {
$query->where('resource_type', (new ServiceApplication)->getMorphClass())
->whereIn('resource_id', $service->applications()->select('id'));
})
->orWhere(function ($query) use ($service) {
$query->where('resource_type', (new ServiceDatabase)->getMorphClass())
->whereIn('resource_id', $service->databases()->select('id'));
})
->get();
}
private function logDrainNetworkConnectCommands(Service $service): array
{
if (! data_get($service, 'connect_to_docker_network')) {
return [];
}
if (! $service->destination?->server?->isFluentBitLogDrainEnabled()) {
return [];
}
$network = data_get($service, 'destination.network');
if (blank($network)) {
return [];
}
return [
'docker network connect '.escapeshellarg($network).' coolify-log-drain >/dev/null 2>&1 || true',
];
}
private function shouldStopBeforeStarting(bool $pullLatestImages, bool $stopBeforeStart): bool
{
return $stopBeforeStart && ! $pullLatestImages;
}
}