mirror of
https://github.com/coollabsio/coolify.git
synced 2026-11-04 10:42:23 +00:00
Andras BacsaiandClaude Opus 5.5
9c6138fe18
The stuck resources cleanup selected every column of every deployment, including logs, and ran out of memory during app:init. Select only the id and application_id. Also drop the unused executions property on the backup pages and an unused execution loader. Closes #12435 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
87 lines
3.4 KiB
PHP
87 lines
3.4 KiB
PHP
<?php
|
|
|
|
use App\Models\Application;
|
|
use App\Models\ApplicationDeploymentQueue;
|
|
use App\Models\Environment;
|
|
use App\Models\InstanceSettings;
|
|
use App\Models\Project;
|
|
use App\Models\ScheduledTask;
|
|
use App\Models\Server;
|
|
use App\Models\StandaloneDocker;
|
|
use App\Models\Team;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Facades\DB;
|
|
use Illuminate\Support\Facades\Queue;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('deletes scheduled tasks whose configured owner no longer exists', function () {
|
|
InstanceSettings::unguarded(fn () => InstanceSettings::firstOrCreate(['id' => 0]));
|
|
Queue::fake();
|
|
|
|
$team = Team::factory()->create();
|
|
$server = Server::factory()->create(['team_id' => $team->id]);
|
|
$destination = StandaloneDocker::where('server_id', $server->id)->firstOrFail();
|
|
$project = Project::factory()->create(['team_id' => $team->id]);
|
|
$environment = $project->environments()->first()
|
|
?? Environment::factory()->create(['project_id' => $project->id]);
|
|
$application = Application::factory()->create([
|
|
'environment_id' => $environment->id,
|
|
'destination_id' => $destination->id,
|
|
'destination_type' => $destination->getMorphClass(),
|
|
]);
|
|
$validTask = ScheduledTask::factory()->create([
|
|
'team_id' => $team->id,
|
|
'application_id' => $application->id,
|
|
]);
|
|
$orphanedTask = ScheduledTask::factory()->create([
|
|
'team_id' => $team->id,
|
|
'application_id' => PHP_INT_MAX,
|
|
]);
|
|
|
|
$this->artisan('cleanup:stucked-resources')->assertSuccessful();
|
|
|
|
expect($validTask->fresh())->not->toBeNull()
|
|
->and($orphanedTask->fresh())->toBeNull();
|
|
});
|
|
|
|
it('deletes orphaned deployments without loading their logs', function () {
|
|
InstanceSettings::unguarded(fn () => InstanceSettings::firstOrCreate(['id' => 0]));
|
|
Queue::fake();
|
|
|
|
$team = Team::factory()->create();
|
|
$server = Server::factory()->create(['team_id' => $team->id]);
|
|
$destination = StandaloneDocker::where('server_id', $server->id)->firstOrFail();
|
|
$project = Project::factory()->create(['team_id' => $team->id]);
|
|
$environment = $project->environments()->first()
|
|
?? Environment::factory()->create(['project_id' => $project->id]);
|
|
$application = Application::factory()->create([
|
|
'environment_id' => $environment->id,
|
|
'destination_id' => $destination->id,
|
|
'destination_type' => $destination->getMorphClass(),
|
|
]);
|
|
$validDeployment = ApplicationDeploymentQueue::create([
|
|
'application_id' => $application->id,
|
|
'deployment_uuid' => 'valid-deployment',
|
|
'server_id' => $server->id,
|
|
'logs' => str_repeat('x', 1000),
|
|
]);
|
|
$orphanedDeployment = ApplicationDeploymentQueue::create([
|
|
'application_id' => PHP_INT_MAX,
|
|
'deployment_uuid' => 'orphaned-deployment',
|
|
'server_id' => $server->id,
|
|
'logs' => str_repeat('x', 1000),
|
|
]);
|
|
|
|
DB::enableQueryLog();
|
|
$this->artisan('cleanup:stucked-resources')->assertSuccessful();
|
|
$deploymentSelects = collect(DB::getQueryLog())
|
|
->pluck('query')
|
|
->filter(fn (string $query) => str_starts_with($query, 'select') && str_contains($query, 'from "application_deployment_queues"'));
|
|
|
|
expect($validDeployment->fresh())->not->toBeNull()
|
|
->and($orphanedDeployment->fresh())->toBeNull()
|
|
->and($deploymentSelects)->not->toBeEmpty()
|
|
->and($deploymentSelects->filter(fn (string $query) => str_contains($query, '*')))->toBeEmpty();
|
|
});
|