mirror of
https://github.com/microsoft/dbt-fabric.git
synced 2026-11-04 12:02:15 +00:00
Pradeep SrikakolapuandCopilot
89c365df2f
## Summary Prepare the 1.12.0 adapter release against published dbt Core 1.12 patches. Raise runtime dependency minimums, refresh the development lockfile through Microsoft's CFS proxy, and document public PyPI setup for external contributors. Published runtime requirements remain independent of the development index. Refresh package compatibility for audit-helper metadata and event bounds, dbt-date timestamp range and precision, dbt-expectations comparisons, external-tables identifier escaping, and profiler statistics and views. Add Fabric artifacts upload serializers and constraint lifecycle macros, including the documented upstream artifacts model/configuration patch. Reject unsupported UDF overloads before they can replace existing functions. Expand unit and functional coverage for Core 1.12 behavior and supported packages. Mark only the two inline-SQL persistence tests as strict expected failures for Core 1.12.0 through 1.12.5, limited to ProgrammingError; retain the active rollback regression and unchanged adapter transaction handling. ## Prompting Intent The engineer asked to finish preparing the dbt-fabric changes, confirm that CFS-backed repository development does not force consumer installs away from their selected index, investigate the functional-test failure, and commit and push the prepared changes to the current remote branch. The engineer explicitly chose strict expected failures for the known upstream inline-SQL bug rather than altering Fabric rollback behavior. Commit the complete prepared change set, including the latest test markers, without publishing a package, creating a release tag, or changing unrelated work. ## Linked Sources - Repository changes and release notes: CHANGELOG.md. - Package behavior, limitations, and tested versions: README.md. - Contributor feed and environment setup: CONTRIBUTING.md. - Dependency requirements and development resolution: pyproject.toml and uv.lock. - Artifacts upstream model/configuration compatibility patch: tests/functional/adapter/fixtures/dbt_artifacts_fabric.patch. - Confirmed upstream transaction bug: https://github.com/dbt-labs/dbt/issues/16784. - Pending upstream transaction fix: https://github.com/dbt-labs/dbt/pull/16785. - Engineer's functional-suite output: 214 passed, 20 skipped, and 2 expected failures across 236 tests on Python 3.11 and Core 1.12.5. - Commit/push authorization and expected-failure decision: current conversation. ## Rationale Use published Core patch releases rather than a Git development dependency for reproducible development and compatibility checks. Keep the shared lockfile on the managed-device CFS feed while leaving published dependencies as ordinary version requirements that consumers resolve through their own index. Use adapter dispatch for Fabric-specific SQL differences. Document the additional artifacts patch where upstream model/configuration branches cannot be corrected by dispatch alone. Preserve Fabric constraint limitations, including non-enforced keys and contract-driven rebuilds for NOT NULL. Retain rollback-on-close and existing materialization commit ownership. The Core task opens an inline-SQL transaction without committing before connection release; weakening adapter transaction safety or adding COMMIT to the persistence regressions would hide that upstream defect. Version-bounded strict expected failures keep the limitation visible, reject unexpected exception types, and surface unexpected passes. Local validation completed: 608 unit tests passed and 1 skipped; package wheel/source builds and lockfile consistency checks passed. The engineer's full functional run had no unexpected failures. The broader local mypy run still reports six untriaged findings, and this commit is for review rather than an assertion of unconditional release readiness. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6f8cfe1b-fa79-422d-8e40-4752d53121e8