Files
docker-agent/pkg/runtime/execution_capabilities_test.go
Djordje Lukic 8d24d42210 refactor(runtime)!: extract remote execution
HTTP/SSE transport, reconnect recovery, and remote OAuth should not be dependencies of local execution. Move their implementations and tests into runtime/remote and migrate remote callers directly, without compatibility re-exports.

Keep the existing Runtime interface, Event types, constructors, and event sinks in runtime. The dependency is intentionally one-way: remote imports runtime, while local execution never imports remote. A regression test enforces this boundary; extracting shared types can be considered separately.
2026-10-26 12:40:23 +01:00

148 lines
6.3 KiB
Go

package runtime
import (
"context"
"encoding/json"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/docker/docker-agent/pkg/agent"
"github.com/docker/docker-agent/pkg/config/latest"
"github.com/docker/docker-agent/pkg/harness"
"github.com/docker/docker-agent/pkg/runtime/inspection"
"github.com/docker/docker-agent/pkg/session"
"github.com/docker/docker-agent/pkg/team"
"github.com/docker/docker-agent/pkg/tools"
)
func nativeExecutionProfile() *inspection.ExecutionCapabilities {
return &inspection.ExecutionCapabilities{
Mode: "native", ToolExecution: "docker-agent", ToolApproval: "docker-agent-policy",
BudgetSupported: true, CompactionSupported: true, MidTurnSteeringSupported: true, PromptHookContextSupported: true,
}
}
func harnessExecutionProfile() *inspection.ExecutionCapabilities {
return &inspection.ExecutionCapabilities{Mode: "harness", ToolExecution: "harness-reported", ToolApproval: "external"}
}
func TestExecutionCapabilitiesProfiles(t *testing.T) {
t.Parallel()
assert.Nil(t, inspection.Capabilities(nil))
assert.Nil(t, (*LocalRuntime)(nil).AgentExecutionCapabilities("native"))
assert.Nil(t, (&LocalRuntime{}).AgentExecutionCapabilities("native"))
assert.Equal(t, nativeExecutionProfile(), inspection.Capabilities(agent.New("native", "")))
assert.Equal(t, harnessExecutionProfile(), inspection.Capabilities(agent.New("harness", "", agent.WithHarness(&latest.HarnessConfig{Type: "codex"}))))
profile := inspection.Capabilities(agent.New("native", ""))
profile.ToolApproval = "changed"
assert.Equal(t, nativeExecutionProfile(), inspection.Capabilities(agent.New("native", "")), "profiles must not share mutable values")
}
type capabilityProbeToolset struct {
calls int
}
func (s *capabilityProbeToolset) Start(context.Context) error { s.calls++; return nil }
func (s *capabilityProbeToolset) Stop(context.Context) error { return nil }
func (s *capabilityProbeToolset) Tools(context.Context) ([]tools.Tool, error) {
s.calls++
return nil, nil
}
func TestExecutionCapabilitiesInspectionIsLazy(t *testing.T) {
t.Parallel()
toolset := &capabilityProbeToolset{}
native := agent.New("native", "", agent.WithModel(&mockProvider{id: "test/model"}), agent.WithToolSets(toolset))
external := agent.New("external", "", agent.WithHarness(&latest.HarnessConfig{Type: "codex"}), agent.WithToolSets(toolset))
factoryCalls := 0
rt, err := NewLocalRuntime(t.Context(), team.New(team.WithAgents(native, external)),
WithModelStore(mockModelStore{}), WithSessionCompaction(false),
WithBudget(&latest.BudgetConfig{MaxTokens: 10}),
WithHarnessFactory(func(*latest.HarnessConfig) (harness.Provider, error) {
factoryCalls++
return nil, nil
}))
require.NoError(t, err)
t.Cleanup(func() { require.NoError(t, rt.Close()) })
for _, tc := range []struct {
name string
want *inspection.ExecutionCapabilities
}{
{"native", nativeExecutionProfile()}, {"external", harnessExecutionProfile()}, {"missing", nil},
} {
assert.Equal(t, tc.want, rt.AgentExecutionCapabilities(tc.name))
assert.Equal(t, tc.want, rt.AgentConfigInfo(t.Context(), tc.name).ExecutionCapabilities)
}
var events []Event
rt.EmitAgentInfo(t.Context(), EventSinkFunc(func(event Event) { events = append(events, event) }))
require.Len(t, events, 2)
assert.Equal(t, nativeExecutionProfile(), events[0].(*AgentInfoEvent).ExecutionCapabilities)
roster := events[1].(*TeamInfoEvent)
require.Len(t, roster.AvailableAgents, 2)
assert.Equal(t, nativeExecutionProfile(), roster.AvailableAgents[0].ExecutionCapabilities)
assert.Equal(t, harnessExecutionProfile(), roster.AvailableAgents[1].ExecutionCapabilities)
assert.Zero(t, toolset.calls)
assert.Zero(t, factoryCalls)
assert.False(t, rt.budgetStarted, "inspection must not initialize budget counters")
require.NoError(t, rt.SetCurrentAgent(t.Context(), "external"))
events = nil
rt.EmitAgentInfo(t.Context(), EventSinkFunc(func(event Event) { events = append(events, event) }))
assert.Equal(t, harnessExecutionProfile(), events[0].(*AgentInfoEvent).ExecutionCapabilities)
}
func TestExecutionCapabilitiesStreamRoster(t *testing.T) {
t.Parallel()
root := agent.New("root", "", agent.WithModel(&mockProvider{id: "test/model", stream: newStreamBuilder().AddContent("reply").AddStopWithUsage(1, 1).Build()}))
external := agent.New("external", "", agent.WithHarness(&latest.HarnessConfig{Type: "codex"}))
rt, err := NewLocalRuntime(t.Context(), team.New(team.WithAgents(root, external)), WithModelStore(mockModelStore{}))
require.NoError(t, err)
t.Cleanup(func() { require.NoError(t, rt.Close()) })
var roster *TeamInfoEvent
for event := range rt.RunStream(t.Context(), session.New(session.WithUserMessage("hello"))) {
if info, ok := event.(*TeamInfoEvent); ok {
roster = info
}
}
require.NotNil(t, roster)
require.Len(t, roster.AvailableAgents, 2)
assert.Equal(t, nativeExecutionProfile(), roster.AvailableAgents[0].ExecutionCapabilities)
assert.Equal(t, harnessExecutionProfile(), roster.AvailableAgents[1].ExecutionCapabilities)
}
func TestExecutionCapabilitiesJSONCompatibility(t *testing.T) {
t.Parallel()
for _, tc := range []struct {
name string
profile *inspection.ExecutionCapabilities
}{
{"unknown", nil}, {"native", nativeExecutionProfile()}, {"harness", harnessExecutionProfile()},
} {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
original := AgentDetails{Name: "root", ExecutionCapabilities: tc.profile}
data, err := json.Marshal(original)
require.NoError(t, err)
var decoded AgentDetails
require.NoError(t, json.Unmarshal(data, &decoded))
assert.Equal(t, original, decoded)
if tc.profile == nil {
assert.NotContains(t, string(data), "execution_capabilities")
} else if tc.name == "harness" {
assert.Contains(t, string(data), `"budget_supported":false`)
assert.Contains(t, string(data), `"prompt_hook_context_supported":false`)
}
})
}
var legacy TeamInfoEvent
require.NoError(t, json.Unmarshal([]byte(`{"type":"team_info","available_agents":[{"name":"root","model":"codex"}],"current_agent":"root"}`), &legacy))
require.Len(t, legacy.AvailableAgents, 1)
assert.Nil(t, legacy.AvailableAgents[0].ExecutionCapabilities)
update := AgentInfo("root", "test/model", "", "")
data, err := json.Marshal(update)
require.NoError(t, err)
assert.NotContains(t, string(data), "execution_capabilities", "model-only updates must not guess capabilities")
}