Files
docker-agent/pkg/memory/database/sqlite/sqlite.go
T
David Gageot a1a2764f1b Enable rowserrcheck linter and fix 3 missing rows.Err() checks
Add rows.Err() checks after row iteration loops in:
- memory/database/sqlite/sqlite.go (GetMemories)
- session/migrations.go (GetAppliedMigrations)
- session/store.go (GetSessionSummaries)

These are correctness bugs: without checking rows.Err(), I/O errors
during iteration would be silently ignored.

Assisted-By: cagent
2026-02-06 17:30:28 +01:00

69 lines
1.7 KiB
Go

package sqlite
import (
"context"
"database/sql"
"github.com/docker/cagent/pkg/memory/database"
"github.com/docker/cagent/pkg/sqliteutil"
)
type MemoryDatabase struct {
db *sql.DB
}
func NewMemoryDatabase(path string) (database.Database, error) {
db, err := sqliteutil.OpenDB(path)
if err != nil {
return nil, err
}
// Ensure we close the connection if table creation fails
// Note: We don't defer close here because we return the db on success
_, err = db.ExecContext(context.Background(), "CREATE TABLE IF NOT EXISTS memories (id TEXT PRIMARY KEY, created_at TEXT, memory TEXT)")
if err != nil {
db.Close()
return nil, err
}
return &MemoryDatabase{db: db}, nil
}
func (m *MemoryDatabase) AddMemory(ctx context.Context, memory database.UserMemory) error {
if memory.ID == "" {
return database.ErrEmptyID
}
_, err := m.db.ExecContext(ctx, "INSERT INTO memories (id, created_at, memory) VALUES (?, ?, ?)",
memory.ID, memory.CreatedAt, memory.Memory)
return err
}
func (m *MemoryDatabase) GetMemories(ctx context.Context) ([]database.UserMemory, error) {
rows, err := m.db.QueryContext(ctx, "SELECT id, created_at, memory FROM memories")
if err != nil {
return nil, err
}
defer rows.Close()
var memories []database.UserMemory
for rows.Next() {
var memory database.UserMemory
err := rows.Scan(&memory.ID, &memory.CreatedAt, &memory.Memory)
if err != nil {
return nil, err
}
memories = append(memories, memory)
}
if err := rows.Err(); err != nil {
return nil, err
}
return memories, nil
}
func (m *MemoryDatabase) DeleteMemory(ctx context.Context, memory database.UserMemory) error {
_, err := m.db.ExecContext(ctx, "DELETE FROM memories WHERE id = ?", memory.ID)
return err
}