Commit Graph
4 Commits
Author SHA1 Message Date
github-actions[bot]andYixuan Wang 921fcc02bd branch-4.1: [fix](sync_point) Fix heap-use-after-free in SyncPoint during program exit #61040 (#61434)
Cherry-picked from #61040

Co-authored-by: Yixuan Wang <wangyixuan@selectdb.com>
2026-03-18 17:35:25 +08:00
Gavin Chou de856351f9 [fix](syncpoint) Fix incorrect syncpoint 'has_point()' intorduced by (#43461) (#43784)
Related PR: #43461
2024-11-12 21:29:10 +08:00
deardeng 92e4857309 [fix](sync point) Fix sync point not reg but construct default value (#43461)
Fix open ENABLE_INJECTION_POINT complie switch, be log

```
W20241107 11:43:11.205868   788 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:11.275723   788 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:11.415167   788 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:11.484220   788 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:11.553351   788 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:11.622395   788 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:11.691509   788 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:11.830601   788 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:11.899286   788 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:11.967985   788 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:13.841727  1032 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:13.945942  1032 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:14.156761  1032 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:38.900395  3064 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:39.397446  3064 status.h:423] meet error status: [IO_ERROR]inject io error
W20241107 11:43:39.896116  3064 status.h:423] meet error status: [IO_ERROR]inject io error
```

For example, in the BE code:
```
TEST_SYNC_POINT_RETURN_WITH_VALUE("LocalFileReader::read_at_impl",
                                   Status::IOError("inject io error"))
```

However, this sync point is not used in the BE, although it is used in
the unit tests. But this macro, when expanded, will construct a default
value, and Status::IOError will print the stack log as soon as it is
constructed.
2024-11-12 10:23:52 +08:00
plat1ko bca8b07d7b [refactor](cloud) Extract SyncPoint to common cpp (#37165)
## Proposed changes

Extract SyncPoint to common cpp directory. Some code shared between BE
and Cloud will gradually be extracted to the `$repo_root/common/cpp`
directory in the future.
2024-07-09 17:07:59 +08:00