mirror of
https://github.com/apache/doris.git
synced 2026-11-04 07:31:17 +00:00
Gabriel
b68d1d5052
### What problem does this PR solve? Related PR: #69312 Port #69312 from `branch-4.2` to current `master`. - Remove Hive ACID read transactions, shared read locks, write-ID snapshots, delta-file listing and the BE transactional reader. Reject full ACID and insert-only reads in the Hive connector. - Adapt the changes to master's connector modules and unified reader initialization interfaces. Preserve ordinary Hive scanning and Iceberg/Paimon ORC position-delete and deletion-vector handling. - Reject standalone Avro and deprecated table markers before file access or metadata-only counts. Keep LakeSoul unsupported and remove its obsolete test service and examples. - Keep the retired `skip_checking_acid_version_file` name as a compatibility no-op for client session initialization, using the existing empty-string fallback for variable reads. - Preserve Iceberg/Hudi Avro metadata dependencies. The Thrift changes add deprecation comments only; every definition and numeric ID is unchanged. ### Release note Remove support for Hive transactional reads, including insert-only tables, and standalone Avro file reads. LakeSoul remains unsupported. Iceberg and Hudi Avro metadata parsing remains supported. The retired `skip_checking_acid_version_file` session variable remains accepted as a compatibility no-op. ### Validation - Hive connector: all 490 tests passed; HMS client: all 155 tests passed. - 20 targeted FE core tests passed: deprecated-read rejection, partition-path parsing, generic file scan planning and Hive streaming scans. - Review follow-up: reproduced the legacy ACID session-variable failure before the fix; all 8 focused compatibility, variable-export and unsupported-read tests passed after the fix. - FE Checkstyle passed with zero violations for every affected FE module. - All 12 affected C++ source/header files passed clang-format 16; build hygiene and shell syntax checks passed. - Syntax-only compilation passed for all 6 affected BE production translation units and all 4 affected BE test translation units. Isolated checks relaxed pre-existing unused-constant/shadow warnings. Full BE linking and runtime tests remain for CI. - Verified that Thrift changes are comments only and checked the affected definitions against branch-3.1/4.0/4.1/4.2. `git diff --check` passed. ### Check List (For Author) - Test - [x] Unit Test - [x] Manual test: formatting, syntax, build hygiene and Thrift compatibility checks described above. - Behavior changed: - [x] Yes. Reject unsupported external reads explicitly. - Does this need documentation? - [x] No. This ports the existing removal to master.