doris

nprasad2077/doris

0 Fork 0

mirror of https://github.com/apache/doris.git synced 2026-11-04 18:02:19 +00:00

Files

T

Gabriel a1ac4dbed7 [fix](hive) Preserve empty text records (#64671 )

### What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

When scanning Hive TEXTFILE tables, Doris previously skipped empty
physical lines unless `read_csv_empty_line_as_null` was enabled. This is
inconsistent with Hive TEXTFILE semantics: an empty physical line is
still a record. For a single-column text table it represents one empty
field, and for multi-column text tables missing trailing fields should
be filled using the table's null format.

This can cause Doris to return fewer rows than Hive for text files
containing empty lines, especially when the table uses `LazySimpleSerDe`
and custom or default `serialization.null.format`.

This PR fixes the behavior by adding a format-level hook for empty-line
handling:

- CSV keeps the existing default behavior and does not treat empty lines
as records.
- Hive TEXT overrides the hook and treats empty physical lines as
records.
- Empty Hive text lines are passed through normal field deserialization
so string/null handling stays consistent with `null_format`.

The PR also adds Hive regression coverage for:

- a single-column text table with custom `serialization.null.format`;
- a multi-column text table using the default Hive null marker `\N`;
- preservation of empty records and correct NULL/empty-string
classification.

In addition, the credit-data Hive fixture upload order is made
refresh-safe. The Hive regression module refresh may rerun all
`data/regression` setup scripts; `crdmm_data` now recreates the Hive
table before re-uploading its HDFS data so `DROP TABLE` cannot remove
freshly uploaded files.

### Release note

Fix Hive TEXTFILE scans to preserve empty physical lines as records,
matching Hive behavior.

### Check List (For Author)

- Test: Regression test
    - Added/updated `external_table_p0/hive/test_hive_serde_prop`.
- Ran `./run-regression-test.sh --run -d external_table_p0/hive -s
test_hive_serde_prop`; local config had `enableHiveTest=false`, so the
Hive test body was skipped.
- Ran `./run-regression-test.sh --run -d external_table_p0/hive -s
test_external_credit_data`; local config had `enableHiveTest=false`, so
the Hive test body was skipped.
- Ran `bash -n
docker/thirdparties/docker-compose/hive/scripts/data/regression/crdmm_data/run.sh`.
    - Ran `git diff --check`.
- Behavior changed: Yes. Hive TEXTFILE scans now preserve empty physical
lines as records instead of skipping them.
- Does this need documentation: No

2026-06-25 15:22:51 +08:00

compilation

[fix](build) Upgrade Maven from 3.6.3 to 3.9.9 in build-env images (#63600 )

2026-06-02 10:13:11 +08:00

runtime

[fix](cloud) Fix some docker case due to open skip_writing_empty_rowset_metadata (#64565 )

2026-06-17 11:33:46 +08:00

thirdparties

[fix](hive) Preserve empty text records (#64671 )

2026-06-25 15:22:51 +08:00

README.md

[chore](orc) Update orc lib to third party lib(1.8.3) using git submodule. (#18531 )

2023-04-12 10:37:50 +08:00

README.md

Doris Develop Environment based on docker

Preparation

Download the Doris code repo
```
$ cd /to/your/workspace/
$ git clone https://github.com/apache/doris.git
$ cd doris
$ git submodule update --init --recursive
```
You can remove the .git dir in doris/ to make the dir size smaller. So that the following generated docker image can be smaller.

Copy Dockerfile

$ cd /to/your/workspace/
$ cp doris/docker/Dockerfile ./

After preparation, your workspace should like this:

.
├── Dockerfile
├── doris
│   ├── be
│   ├── bin
│   ├── build.sh
│   ├── conf
│   ├── DISCLAIMER-WIP
│   ├── docker
│   ├── docs
│   ├── env.sh
│   ├── fe
│   ├── ...

Build docker image

$ cd /to/your/workspace/
$ docker build -t doris:v1.0  .

doris is docker image repository name and v1.0 is tag name, you can change them to whatever you like.

Use docker image

This docker image you just built does not contain Doris source code repo. You need to download it first and map it to the container. (You can just use the one you used to build this image before)

$ docker run -it -v /your/local/path/doris/:/root/doris/ doris:v1.0
$ docker run -it -v /your/local/.m2:/root/.m2 -v /your/local/doris-DORIS-x.x.x-release/:/root/doris-DORIS-x.x.x-release/ doris:v1.0

Then you can build source code inside the container.

$ cd /root/doris/
$ sh build.sh

NOTICE

The default JDK version is openjdk 11, if you want to use openjdk 8, you can run the command:

$ alternatives --set java java-1.8.0-openjdk.x86_64
$ alternatives --set javac java-1.8.0-openjdk.x86_64
$ export JAVA_HOME=/usr/lib/jvm/java-1.8.0

The version of jdk you used to run FE must be the same version you used to compile FE.

Latest update time

2022-1-23