nprasad2077/oxc
1
0 Fork 0
mirror of https://github.com/oxc-project/oxc.git synced 2026-11-04 10:29:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(linter/unicorn/no-static-only-class): bound token lookup (#25361)

Browse Source 
## Summary
Bound the semicolon lookup to the current class member span.

## Details
- Use `find_next_token_within` to locate the target semicolon.
- Preserve the existing dangerous-fix behavior and member cleanup.
This commit is contained in:
camc314 committed 2026-08-07 14:24:54 +00:00
1 parent a33788e13e
commit 03b2eb23ef
1 file changed
+3 -26
Download Patch File Download Diff File Expand all files Collapse all files
crates/oxc_linter/src/rules/unicorn/no_static_only_class.rs
+3 -26
View File
@@ -111,7 +111,6 @@ impl Rule for NoStaticOnlyClass {
}) {
return;
}
#[expect(clippy::cast_possible_truncation)]
ctx.diagnostic_with_dangerous_fix(no_static_only_class_diagnostic(class.span), |fixer| {
if with_type_annotation
|| class.is_typescript_syntax()
@@ -154,31 +153,9 @@ impl Rule for NoStaticOnlyClass {
} else {
class.body.span.end
};
let mut search_start = item.span().end;
let mut target_semicolon_pos = None;
while search_start < next_start {
if let Some(pos) = ctx
.source_range(Span::new(search_start, next_start))
.find(';')
.map(|p| search_start + (p as u32))
{
let comments = ctx.comments_range(item.span().end..next_start);
let mut is_in_comment = false;
for comment in comments {
if comment.span.start < pos && comment.span.end > pos {
is_in_comment = true;
break;
}
}
if !is_in_comment {
target_semicolon_pos = Some(pos);
break;
}
search_start = pos + 1;
} else {
break;
}
}
let target_semicolon_pos = ctx
.find_next_token_within(item.span().end, next_start, ";")
.map(|offset| item.span().end + offset);
if let Some(pos) = target_semicolon_pos {
rule_fixes.push(fixer.delete_range(Span::sized(pos, 1)));
}