nprasad2077/oxc
1
0 Fork 0
mirror of https://github.com/oxc-project/oxc.git synced 2026-11-04 10:29:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(parser): skip duplicate lookup for singleton import attributes (#28441)

Browse Source 
Avoid constructing the duplicate-key map when an import attribute list
has fewer than two entries.

Validated with scoped Rust checks, full conformance, parser bindings,
allocation tracking.

AI-assisted (Codex).
This commit is contained in:
Boshen authored and GitHub committed 2026-10-30 11:36:23 +08:00
1 parent a1e7e5f13e
commit 10e9fc7f81
1 file changed
+9 -7
Download Patch File Download Diff File Expand all files Collapse all files
crates/oxc_parser/src/js/module.rs
+9 -7
View File
@@ -387,13 +387,15 @@ impl<'a, C: Config> ParserImpl<'a, C> {
});
self.expect(Kind::RCurly);
let mut keys = FxHashMap::default();
for e in &with_entries {
let key = e.key.as_js_str();
let span = e.key.span();
if let Some(old_span) = keys.insert(key, span) {
let name = key.as_str().unwrap_or_else(|| span.source_text(self.source_text));
self.error(diagnostics::duplicate_import_attribute_key(name, old_span, span));
if with_entries.len() > 1 {
let mut keys = FxHashMap::default();
for e in &with_entries {
let key = e.key.as_js_str();
let span = e.key.span();
if let Some(old_span) = keys.insert(key, span) {
let name = key.as_str().unwrap_or_else(|| span.source_text(self.source_text));
self.error(diagnostics::duplicate_import_attribute_key(name, old_span, span));
}
}
}