mirror of
https://github.com/oxc-project/oxc.git
synced 2026-11-04 10:29:58 +00:00
feat(parser): add TS1054 code to diagnostic (#18541)
https://github.com/microsoft/typescript/blob/7affa9e5403035b6d281616e6651529e7387f253/src/compiler/diagnosticMessages.json#L162-L165
This commit is contained in:
1 parent
823a73c70e
commit
1117c446a0
4 files changed
+13
-13
No files matched your search
@@ -1148,7 +1148,7 @@ pub fn setter_with_rest_parameter(span: Span) -> OxcDiagnostic {
|
||||
|
||||
#[cold]
|
||||
pub fn getter_parameters(span: Span) -> OxcDiagnostic {
|
||||
OxcDiagnostic::error("A 'get' accessor must not have any formal parameters.")
|
||||
ts_error("1054", "A 'get' accessor must not have any formal parameters.")
|
||||
.with_label(span)
|
||||
.with_help("Remove these parameters here")
|
||||
}
|
||||
|
||||
@@ -781,7 +781,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
|
||||
· ────────
|
||||
╰────
|
||||
|
||||
× A 'get' accessor must not have any formal parameters.
|
||||
× TS(1054): A 'get' accessor must not have any formal parameters.
|
||||
╭─[babel/packages/babel-parser/test/fixtures/core/object/invalid-getter-param/input.js:1:12]
|
||||
1 │ ({ get prop(x) {} })
|
||||
· ───
|
||||
@@ -2633,7 +2633,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
|
||||
3 │ }
|
||||
╰────
|
||||
|
||||
× A 'get' accessor must not have any formal parameters.
|
||||
× TS(1054): A 'get' accessor must not have any formal parameters.
|
||||
╭─[babel/packages/babel-parser/test/fixtures/es2015/class-methods/getter-signature/input.js:2:12]
|
||||
1 │ class A {
|
||||
2 │ get prop (arg) {}
|
||||
@@ -4371,7 +4371,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
|
||||
· ─────
|
||||
╰────
|
||||
|
||||
× A 'get' accessor must not have any formal parameters.
|
||||
× TS(1054): A 'get' accessor must not have any formal parameters.
|
||||
╭─[babel/packages/babel-parser/test/fixtures/es2015/uncategorised/345/input.js:1:19]
|
||||
1 │ class A { get prop(x) {} }
|
||||
· ───
|
||||
@@ -12051,7 +12051,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
|
||||
╰────
|
||||
help: Add a parameter here
|
||||
|
||||
× A 'get' accessor must not have any formal parameters.
|
||||
× TS(1054): A 'get' accessor must not have any formal parameters.
|
||||
╭─[babel/packages/babel-parser/test/fixtures/estree/typescript/getter-setter/input.ts:4:9]
|
||||
3 │ ({ set x() {} });
|
||||
4 │ ({ get x(x) {} });
|
||||
@@ -13287,7 +13287,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
|
||||
3 │ }
|
||||
╰────
|
||||
|
||||
× A 'get' accessor must not have any formal parameters.
|
||||
× TS(1054): A 'get' accessor must not have any formal parameters.
|
||||
╭─[babel/packages/babel-parser/test/fixtures/typescript/interface/get-set-invalid-parameters/input.ts:2:10]
|
||||
1 │ interface Foo {
|
||||
2 │ get foo(param): string;
|
||||
|
||||
@@ -14208,7 +14208,7 @@ Negative Passed: 4581/4581 (100.00%)
|
||||
34 │ throw new Test262Error();
|
||||
╰────
|
||||
|
||||
× A 'get' accessor must not have any formal parameters.
|
||||
× TS(1054): A 'get' accessor must not have any formal parameters.
|
||||
╭─[test262/test/language/expressions/class/getter-param-dflt.js:24:17]
|
||||
23 │
|
||||
24 │ 0, class { get a(param = null) {} };
|
||||
@@ -18625,7 +18625,7 @@ Negative Passed: 4581/4581 (100.00%)
|
||||
20 │ }
|
||||
╰────
|
||||
|
||||
× A 'get' accessor must not have any formal parameters.
|
||||
× TS(1054): A 'get' accessor must not have any formal parameters.
|
||||
╭─[test262/test/language/expressions/object/getter-param-dflt.js:24:11]
|
||||
23 │
|
||||
24 │ 0, { get a(param = null) {} };
|
||||
@@ -33319,7 +33319,7 @@ Negative Passed: 4581/4581 (100.00%)
|
||||
34 │ throw new Test262Error();
|
||||
╰────
|
||||
|
||||
× A 'get' accessor must not have any formal parameters.
|
||||
× TS(1054): A 'get' accessor must not have any formal parameters.
|
||||
╭─[test262/test/language/statements/class/getter-param-dflt.js:24:16]
|
||||
23 │
|
||||
24 │ class C { get a(param = null) {} }
|
||||
|
||||
@@ -4031,7 +4031,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
|
||||
╰────
|
||||
help: Try inserting a semicolon here
|
||||
|
||||
× A 'get' accessor must not have any formal parameters.
|
||||
× TS(1054): A 'get' accessor must not have any formal parameters.
|
||||
╭─[typescript/tests/cases/compiler/complicatedPrivacy.ts:11:26]
|
||||
10 │ export class C2 implements m3.i3 {
|
||||
11 │ public get p1(arg) {
|
||||
@@ -6425,7 +6425,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
|
||||
13 │ }
|
||||
╰────
|
||||
|
||||
× A 'get' accessor must not have any formal parameters.
|
||||
× TS(1054): A 'get' accessor must not have any formal parameters.
|
||||
╭─[typescript/tests/cases/compiler/gettersAndSettersErrors.ts:6:19]
|
||||
5 │ public Foo = 0; // error - duplicate identifier Foo - confirmed
|
||||
6 │ public get Goo(v:string):string {return null;} // error - getters must not have a parameter
|
||||
@@ -21146,7 +21146,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
|
||||
╰────
|
||||
help: No modifiers are allowed here.
|
||||
|
||||
× A 'get' accessor must not have any formal parameters.
|
||||
× TS(1054): A 'get' accessor must not have any formal parameters.
|
||||
╭─[typescript/tests/cases/conformance/parser/ecmascript5/Accessors/parserAccessors7.ts:1:18]
|
||||
1 │ var v = { get foo(v: number) { } };
|
||||
· ───────────
|
||||
@@ -22485,7 +22485,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
|
||||
3 │ }
|
||||
╰────
|
||||
|
||||
× A 'get' accessor must not have any formal parameters.
|
||||
× TS(1054): A 'get' accessor must not have any formal parameters.
|
||||
╭─[typescript/tests/cases/conformance/parser/ecmascript5/MemberAccessorDeclarations/parserMemberAccessorDeclaration12.ts:2:11]
|
||||
1 │ class C {
|
||||
2 │ get Foo(a: number) { }
|
||||
|
||||
Reference in new issue
Block a user