perf(linter/oxc/number-arg-out-of-range): narrow AST dispatch (#28355)

Start from numeric literals used as direct first arguments. Preserve
range boundaries and optional calls, and reduce fixture callbacks from
62,606 to 14,295.


---

<sub>Stack created with <a
href="https://github.com/github/gh-stack">GitHub Stacks CLI</a> • <a
href="https://gh.io/stacks-feedback">Give Feedback 💬</a></sub>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

crates/oxc_linter/src/generated/rule_runner_impls.rs

@@ -4448,7 +4448,7 @@ impl RuleRunner for crate::rules::oxc::no_this_in_exported_function::NoThisInExp
 
 impl RuleRunner for crate::rules::oxc::number_arg_out_of_range::NumberArgOutOfRange {
     const NODE_TYPES: Option<&AstTypesBitset> =
-        Some(&AstTypesBitset::from_types(&[AstType::CallExpression]));
+        Some(&AstTypesBitset::from_types(&[AstType::NumericLiteral]));
     const RUN_FUNCTIONS: RuleRunFunctionsImplemented = RuleRunFunctionsImplemented::Run;
 }
 

crates/oxc_linter/src/rules/oxc/number_arg_out_of_range.rs

@@ -1,7 +1,7 @@
-use oxc_ast::{AstKind, ast::Argument};
+use oxc_ast::AstKind;
 use oxc_diagnostics::OxcDiagnostic;
 use oxc_macros::declare_oxc_lint;
-use oxc_span::Span;
+use oxc_span::{GetSpan, Span};
 use oxc_str::JSStr;
 
 use crate::{AstNode, context::LintContext, rule::Rule};
@@ -58,9 +58,12 @@ declare_oxc_lint!(
 
 impl Rule for NumberArgOutOfRange {
     fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
-        if let AstKind::CallExpression(expr) = node.kind()
+        let AstKind::NumericLiteral(literal) = node.kind() else {
+            return;
+        };
+        if let AstKind::CallExpression(expr) = ctx.nodes().parent_kind(node.id())
+            && expr.arguments.first().is_some_and(|argument| argument.span() == literal.span)
             && let Some(member) = expr.callee.get_member_expr()
-            && let Some(Argument::NumericLiteral(literal)) = expr.arguments.first()
         {
             let value = literal.value;
             match member.static_property_name().and_then(JSStr::as_str) {
@@ -85,7 +88,21 @@ impl Rule for NumberArgOutOfRange {
 fn test() {
     use crate::tester::Tester;
 
-    let pass = vec![("var x = 42;var s = x.toString(16);", None)];
+    let pass = vec![
+        ("var x = 42;var s = x.toString(16);", None),
+        ("x.toString(2); x.toString(36)", None),
+        ("x.toFixed(0); x.toFixed(20)", None),
+        ("x.toExponential(0); x.toExponential(20)", None),
+        ("x.toPrecision(1); x.toPrecision(21)", None),
+        ("x.toString(16, 1)", None),
+        ("x.toString((1))", None),
+        ("x.toString(1 as number)", None),
+        ("x.toString(-1)", None),
+        ("x.toString(...[1])", None),
+        ("new x.toString(1)", None),
+        ("x.toString()", None),
+        ("x.otherMethod(100)", None),
+    ];
 
     let fail = vec![
         ("var x = 42;var s = x.toString(1);", None),
@@ -94,6 +111,8 @@ fn test() {
         ("var x = 42;var s = x['toExponential'](22);", None),
         ("var x = 42;var s = x.toPrecision(0);", None),
         ("var x = 42;var s = x.toPrecision(100);", None),
+        ("x.toString(1, 43)", None),
+        ("x?.toFixed(22)", None),
     ];
 
     Tester::new(NumberArgOutOfRange::NAME, NumberArgOutOfRange::PLUGIN, pass, fail)

crates/oxc_linter/src/snapshots/oxc_number_arg_out_of_range.snap

@@ -43,3 +43,17 @@ source: crates/oxc_linter/src/tester.rs
    ·                    ──────────────────
    ╰────
   help: The first argument of 'Number.prototype.toPrecision' should be a number between 1 and 21
+
+  ⚠ oxc(number-arg-out-of-range): Radix or precision arguments of number-related functions should not exceed the limit
+   ╭─[number_arg_out_of_range.tsx:1:1]
+ 1 │ x.toString(1, 43)
+   · ─────────────────
+   ╰────
+  help: The first argument of 'Number.prototype.toString' should be a number between 2 and 36
+
+  ⚠ oxc(number-arg-out-of-range): Radix or precision arguments of number-related functions should not exceed the limit
+   ╭─[number_arg_out_of_range.tsx:1:1]
+ 1 │ x?.toFixed(22)
+   · ──────────────
+   ╰────
+  help: The first argument of 'Number.prototype.toFixed' should be a number between 0 and 20

tasks/track_linter_timings/linter_timings.snap

@@ -355,7 +355,7 @@ oxc/no-map-spread                                       |  62606
 oxc/no-optional-chaining                                |    792
 oxc/no-rest-spread-properties                           |    564
 oxc/no-this-in-exported-function                        |    112
-oxc/number-arg-out-of-range                             |  62606
+oxc/number-arg-out-of-range                             |  14295
 oxc/only-used-in-recursion                              |  16812
 oxc/uninvoked-array-callback                            |   1421
 promise/always-return                                   |  16812