From 444f24ad82b469bfd9fc3e440f5f417e9b95c64f Mon Sep 17 00:00:00 2001 From: Boshen Date: Fri, 30 Oct 2026 17:17:31 +0800 Subject: [PATCH] perf(ecmascript): short-circuit simple parameter checks for rest (#28503) Return immediately for rest parameters before scanning the ordinary parameters. AI-assisted (Codex). --- crates/oxc_ecmascript/src/is_simple_parameter_list.rs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/crates/oxc_ecmascript/src/is_simple_parameter_list.rs b/crates/oxc_ecmascript/src/is_simple_parameter_list.rs index 5d8954f7fe..5c890bb170 100644 --- a/crates/oxc_ecmascript/src/is_simple_parameter_list.rs +++ b/crates/oxc_ecmascript/src/is_simple_parameter_list.rs @@ -7,9 +7,10 @@ pub trait IsSimpleParameterList { impl IsSimpleParameterList for FormalParameters<'_> { fn is_simple_parameter_list(&self) -> bool { - self.items - .iter() - .all(|pat| pat.pattern.is_binding_identifier() && pat.initializer.is_none()) - && self.rest.is_none() + self.rest.is_none() + && self + .items + .iter() + .all(|pat| pat.pattern.is_binding_identifier() && pat.initializer.is_none()) } }