From b1def652d3a3f70a04053b4e1ba6d8480e90ceb3 Mon Sep 17 00:00:00 2001 From: Yuji Sugiura <6259812+leaysgur@users.noreply.github.com> Date: Fri, 30 Oct 2026 16:40:34 +0900 Subject: [PATCH] test(formatter_htmlish): rename `nul` fixture directory for Windows (#28522) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `crates/oxc_formatter_htmlish/tests/fixtures/html/nul/` (added in #28272) uses `nul`, a reserved device name on Windows, which breaks all Windows jobs on main: - `Test Windows`: `error: invalid path 'crates/oxc_formatter_htmlish/tests/fixtures/html/nul/nul-as-written.html'` - `Test NAPI * (windows)`: `Could not find a part of the path '\\.\nul'` while downloading the repo as a local action Renamed the directory to `nul-byte/` and updated the `.gitattributes` entry and the `DIVERGENCES.md` pin. The snapshot content is unchanged. `cargo test -p oxc_formatter_htmlish` passes (`fixtures::html::nul_byte::nul_as_written` included). This PR was created with AI assistance (Claude Code). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 --- .gitattributes | 2 +- crates/oxc_formatter_htmlish/DIVERGENCES.md | 2 +- .../html/{nul => nul-byte}/nul-as-written.html | Bin .../html/{nul => nul-byte}/nul-as-written.html.snap | Bin 4 files changed, 2 insertions(+), 2 deletions(-) rename crates/oxc_formatter_htmlish/tests/fixtures/html/{nul => nul-byte}/nul-as-written.html (100%) rename crates/oxc_formatter_htmlish/tests/fixtures/html/{nul => nul-byte}/nul-as-written.html.snap (100%) diff --git a/.gitattributes b/.gitattributes index 6168438f90..4b8fb68d50 100644 --- a/.gitattributes +++ b/.gitattributes @@ -8,7 +8,7 @@ crates/oxc_formatter_graphql/tests/fixtures/graphql/crlf/** text=auto eol=crlf crates/oxc_formatter_htmlish/tests/fixtures/** text=auto eol=lf crates/oxc_formatter_htmlish/tests/fixtures/html/crlf/** text=auto eol=crlf # NUL bytes would make git read these as binary -crates/oxc_formatter_htmlish/tests/fixtures/html/nul/** text eol=lf diff +crates/oxc_formatter_htmlish/tests/fixtures/html/nul-byte/** text eol=lf diff crates/oxc_formatter_yaml/tests/fixtures/** text=auto eol=lf crates/oxc_formatter_yaml/tests/fixtures/yaml/crlf/** text=auto eol=crlf crates/oxc_formatter_markdown/tests/fixtures/** text=auto eol=lf diff --git a/crates/oxc_formatter_htmlish/DIVERGENCES.md b/crates/oxc_formatter_htmlish/DIVERGENCES.md index 6f96b818e8..d0b2565b25 100644 --- a/crates/oxc_formatter_htmlish/DIVERGENCES.md +++ b/crates/oxc_formatter_htmlish/DIVERGENCES.md @@ -305,7 +305,7 @@ Between blocks, where it usually sits, the output is the same. ## nul-as-written - Why: semantics (Prettier drops everything after a NUL between tags) -- Pin: `tests/fixtures/html/nul/nul-as-written.html` +- Pin: `tests/fixtures/html/nul-byte/nul-as-written.html` ```html diff --git a/crates/oxc_formatter_htmlish/tests/fixtures/html/nul/nul-as-written.html b/crates/oxc_formatter_htmlish/tests/fixtures/html/nul-byte/nul-as-written.html similarity index 100% rename from crates/oxc_formatter_htmlish/tests/fixtures/html/nul/nul-as-written.html rename to crates/oxc_formatter_htmlish/tests/fixtures/html/nul-byte/nul-as-written.html diff --git a/crates/oxc_formatter_htmlish/tests/fixtures/html/nul/nul-as-written.html.snap b/crates/oxc_formatter_htmlish/tests/fixtures/html/nul-byte/nul-as-written.html.snap similarity index 100% rename from crates/oxc_formatter_htmlish/tests/fixtures/html/nul/nul-as-written.html.snap rename to crates/oxc_formatter_htmlish/tests/fixtures/html/nul-byte/nul-as-written.html.snap