Jamie
cb0b56d408
### What problem does this PR solve? Issue Number: None Related PR: #64574 Problem Summary: `is_tablet_encrypted()`, which serves `/api/check_tablet_encryption`, holds the tablet `_meta_lock` read lock in `traverse_rowsets()` and takes it again through `tablet_schema()` in the visitor. Since #64574 `_meta_lock` is the writer-preferring `BthreadSharedMutex`, so a writer that arrives between the two reads deadlocks with the check: - The check holds the first read lock and waits for the second, which is blocked by the pending writer. - The writer waits for the first read lock to be released. The window is wide because each rowset's files are read from remote storage under the lock, and compaction and rowset sync take the write lock often. Once this happens the tablet stays stuck until the BE restarts: - The HTTP request never returns. - The compaction keeps renewing its lease but never finishes, so other BEs get `JOB_TABLET_BUSY` for this tablet. - Every later reader of this tablet's meta blocks behind the pending writer, including the periodic tablet sync. We hit this in a regression test: the compaction stopped right after its rowset sync, and the check timed out on all 10 retries over about 2h47m. This PR reads the schema once before the check and checks a snapshot of the rowsets (`get_snapshot_rowset()`) with no lock held, which also stops holding the meta lock across remote file reads. It adds a test-only sync point so a unit test can observe the lock at that moment. ### Release note Fix a deadlock between the tablet encryption check API and tablet meta writers such as compaction, which could block a tablet until the BE restarts. ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [x] Unit Test - [x] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> Unit test `CheckEncryptionActionTest.RowsetsAreCheckedWithoutHoldingMetaLock` checks that `_meta_lock` is free while a rowset is being checked. It fails on the code before this PR and passes with it. Manual test: a temporary unit test (not committed) started a writer from inside the rowset check, then waited for the check to return. On the code before this PR the check had not returned after 20s. With this PR it returned at once. - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214
🌍 Read this in other language
English • العربية • বাংলা • Deutsch • Español • فارسی • Français • हिन्दी • Bahasa Indonesia • Italiano • 日本語 • 한국어 • Polski • Português • Română • Русский • Slovenščina • ไทย • Türkçe • Українська • Tiếng Việt • 简体中文 • 繁體中文
?style=for-the-badge){kind=icon}
?style=for-the-badge){kind=icon}
Apache Doris is an open-source, real-time analytics and search database built on MPP architecture. It provides fast SQL analytics, lakehouse query acceleration, and hybrid search across structured, text, and vector data.
Explore the official website for the latest product overview, use cases, ecosystem updates, blogs, and user stories. For version updates, see all release notes.
📈 Use Cases
| Use Case | What it provides |
|---|---|
| Customer-Facing Analytics | Ship sub-second interactive analytics to external users. |
| Data Warehousing | Build one real-time warehouse across business domains. |
| Observability | Analyze high-throughput logs, events, and metrics with SQL. |
| Doris for AI | Use vector, text, JSON, and structured search in one SQL engine. |
🚀 Core Capabilities
Apache Doris is built around three core capabilities. The website is the source of truth for detailed product descriptions and examples.
| Capability | What it provides |
|---|---|
| Real-Time Analytics | Streaming ingestion, incremental transformation, and sub-second queries under high concurrency. |
| Lakehouse Analytics | Fast SQL analytics over open table formats such as Iceberg, Delta Lake, and Hudi. |
| Hybrid Search | SQL-native analytics across JSON, full-text, and vector data for AI and search workloads. |
🔌 Ecosystem
Doris sits at the center of the modern data stack. It connects upstream databases, streaming systems, and lakehouse storage with downstream BI, AI, analytics, and observability tools.
For the latest ecosystem coverage, visit the official website and the connection and integration documentation.
👣 Get Started
🧱 Architecture
Apache Doris supports both compute-storage coupled and compute-storage decoupled deployments. In decoupled mode, stateless compute groups run over shared object storage, so you can scale compute on demand and isolate workloads.
Learn more in the deployment guide and deployment mode guide.
📣 Project Updates
| Resource | What it provides |
|---|---|
| Community Report | Weekly updates on community activity, merged PRs, contributors, and feature progress. |
| Roadmap 2026 | The 2026 planning discussion for AI and hybrid search, query engine, storage, and data lake work. |
🧩 Components
Doris provides connectors and tools for common data engineering workflows.
- Doris Flink Connector
- Doris Spark Connector
- Doris Kafka Connector
- Doris Stream Loader
- Doris Kubernetes Operator
👨👩👧👦 Users
Apache Doris is used in production by thousands of companies worldwide across internet services, finance, retail, logistics, manufacturing, energy, telecommunications, AI, and other industries.
🙌 Contributors
Apache Doris graduated from the Apache Incubator and became an Apache Top-Level Project in June 2022. Thanks to all community contributors who help build Doris.
🌈 Community and Support
💬 Contact Us
🧰 Links
- Apache Doris official website: doris.apache.org
- X: @doris_apache
- Medium: @ApacheDoris
📜 License
Note
Some licenses of the third-party dependencies are not compatible with Apache 2.0 License. So you need to disable some Doris features to comply with Apache 2.0 License. For details, refer to the
thirdparty/LICENSE.txt