nprasad2077/kafka
1
0 Fork 0
mirror of https://github.com/apache/kafka.git synced 2026-11-04 04:44:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: Fix log and exception messages in GroupMetadataManager (#24030)

Browse Source 
Several log and exception messages in `GroupMetadataManager` have a
stray `}` in a placeholder, a missing space, a doubled period or the
wrong term, and one share group tombstone check does not use the message
of its consumer and streams counterparts.

This patch fixes them.

Reviewers: Sean Quah <squah@confluent.io>
This commit is contained in:
David Jacot authored and GitHub committed 2026-10-30 21:36:44 +01:00
1 parent bd83759710
commit 3e347f1f5c
1 file changed
+7 -7
Download Patch File Download Diff File Expand all files Collapse all files
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java
+7 -7
View File
@@ -1381,7 +1381,7 @@ public class GroupMetadataManager {
log.warn("Cannot downgrade the consumer group {}: fail to parse the Consumer Protocol {}.",
consumerGroup.groupId(), ConsumerProtocol.PROTOCOL_TYPE, e);
throw new GroupIdNotFoundException(String.format("Cannot downgrade the classic group %s: %s.",
throw new GroupIdNotFoundException(String.format("Cannot downgrade the consumer group %s: %s.",
consumerGroup.groupId(), e.getMessage()));
}
classicGroup.createClassicGroupRecords(records);
@@ -2306,7 +2306,7 @@ public class GroupMetadataManager {
group.storedDescriptionTopologyEpoch(),
group.failedDescriptionTopologyEpoch()
));
log.info("[GroupId {}][MemberId {}] Bumped streams group epoch to {} with metadata hash {} and validated topic epoch {}.", groupId, memberId, groupEpoch, metadataHash, validatedTopologyEpoch);
log.info("[GroupId {}][MemberId {}] Bumped streams group epoch to {} with metadata hash {} and validated topology epoch {}.", groupId, memberId, groupEpoch, metadataHash, validatedTopologyEpoch);
metrics.record(STREAMS_GROUP_REBALANCES_SENSOR_NAME);
group.setMetadataRefreshDeadline(currentTimeMs + METADATA_REFRESH_INTERVAL_MS, groupEpoch);
}
@@ -5373,7 +5373,7 @@ public class GroupMetadataManager {
streamsGroupSessionTimeoutMs(groupId),
TimeUnit.MILLISECONDS,
true,
() -> streamsGroupFenceMemberOperation(groupId, memberId, "the member session expired.")
() -> streamsGroupFenceMemberOperation(groupId, memberId, "the member session expired")
);
}
@@ -5588,7 +5588,7 @@ public class GroupMetadataManager {
return new CoordinatorResult<>(List.of());
}
} catch (GroupIdNotFoundException ex) {
log.debug("[GroupId {}] Could not fence {}} because the group does not exist.",
log.debug("[GroupId {}] Could not fence {} because the group does not exist.",
groupId, memberId);
} catch (UnknownMemberIdException ex) {
log.debug("[GroupId {}] Could not fence {} because the member does not exist.",
@@ -5631,7 +5631,7 @@ public class GroupMetadataManager {
return new CoordinatorResult<>(List.of());
}
} catch (GroupIdNotFoundException ex) {
log.debug("[GroupId {}] Could not fence {}} because the group does not exist.",
log.debug("[GroupId {}] Could not fence {} because the group does not exist.",
groupId, memberId);
} catch (UnknownMemberIdException ex) {
log.debug("[GroupId {}] Could not fence {} because the member does not exist.",
@@ -6512,7 +6512,7 @@ public class GroupMetadataManager {
}
if (shareGroup.assignmentEpoch() != -1) {
throw new IllegalStateException("Received a tombstone record to delete group " + groupId
+ " but target assignment epoch in invalid.");
+ " but did not receive ShareGroupTargetAssignmentMetadataValue tombstone.");
}
removeGroup(groupId);
}
@@ -8485,7 +8485,7 @@ public class GroupMetadataManager {
if (t != null) {
Errors error = appendGroupMetadataErrorToResponseError(Errors.forException(t));
resetAndPropagateAssignmentWithError(group, error);
maybePrepareRebalanceOrCompleteJoin(group, "Error " + error + " when storing group assignment" +
maybePrepareRebalanceOrCompleteJoin(group, "Error " + error + " when storing group assignment " +
"during SyncGroup (member: " + memberId + ").");
} else {
// Update group's assignment and propagate to all members.