mirror of
https://github.com/microsoft/mcp.git
synced 2026-11-04 12:01:31 +00:00
Sync eng/common directory with azure-sdk-tools for PR 17393 (#4043)
* Pass optional SDK PRs safely to shared release completion * Address shared release completion review feedback --------- Co-authored-by: helen229 <gaoh@microsoft.com>
This commit is contained in:
1 parent
3736f3e93e
commit
6147a8cb30
2 files changed
+17
-1
No files matched your search
@@ -0,0 +1,7 @@
|
||||
# Common engineering release history
|
||||
|
||||
## Unreleased
|
||||
|
||||
### Bugs Fixed
|
||||
|
||||
- Release-plan completion uses the job's `AutoReleaseSdkPullRequestUrl` when no explicit `SdkPullRequest` is supplied. An absent or empty variable is initialized to an empty string at runtime before macro expansion, so manual runs do not pass an unresolved variable. Empty initialization is logged. Existing runtime values and explicit parameters are preserved.
|
||||
@@ -10,6 +10,15 @@ steps:
|
||||
parameters:
|
||||
SourceRootPath: ${{ parameters.SourceRootPath }}
|
||||
|
||||
# Runtime output variables must not be tested at template-expansion time.
|
||||
# Initialize the optional macro before use on manual runs that have no SDK PR.
|
||||
- ${{ if eq(parameters.SdkPullRequest, '') }}:
|
||||
- pwsh: |
|
||||
Write-Host '##vso[task.setvariable variable=AutoReleaseSdkPullRequestUrl]'
|
||||
Write-Host 'AutoReleaseSdkPullRequestUrl is set to an empty string.'
|
||||
displayName: Initialize optional auto-release SDK PR
|
||||
condition: and(succeeded(), ne(variables['Skip.MarkReleaseCompletion'], 'true'), eq(variables['AutoReleaseSdkPullRequestUrl'], ''))
|
||||
|
||||
- task: AzureCLI@2
|
||||
inputs:
|
||||
azureSubscription: opensource-api-connection
|
||||
@@ -19,7 +28,7 @@ steps:
|
||||
arguments: >
|
||||
-PackageInfoFilePath '${{ parameters.ConfigFileDir }}/${{ parameters.PackageArtifactName }}.json' -AzsdkExePath '$(AZSDK)'
|
||||
-ReleasePlanId '${{ parameters.ReleasePlanId }}'
|
||||
-SdkPullRequest '${{ parameters.SdkPullRequest }}'
|
||||
-SdkPullRequest '${{ coalesce(parameters.SdkPullRequest, '$(AutoReleaseSdkPullRequestUrl)') }}'
|
||||
-PipelineUrl "$(System.CollectionUri)$(System.TeamProject)/_build/results?buildId=$(Build.BuildId)"
|
||||
workingDirectory: $(Pipeline.Workspace)
|
||||
displayName: Mark package as released
|
||||
|
||||
Reference in new issue
Block a user