nprasad2077/oxc
1
0 Fork 0
mirror of https://github.com/oxc-project/oxc.git synced 2026-11-04 10:29:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(lexer): reorder code (#28696)

Browse Source 
Pure refactor. Move a function, to make a more logical order.
This commit is contained in:
overlookmotel committed 2026-11-02 04:08:43 +00:00
1 parent 7bd0eeaee4
commit 3c85661446
1 file changed
+21 -21
Download Patch File Download Diff File Expand all files Collapse all files
crates/oxc_lexer/src/cpu/mod.rs
+21 -21
View File
@@ -98,27 +98,6 @@ trait CpuPrivate {
const DYN_CPU: Option<DynCpu>;
}
/// Get the [`DynCpu`] for a type implementing [`Cpu`].
///
/// Same as [`Cpu::to_dyn`], but this works in `const` code too.
/// A `const fn` can't call a trait method on a generic type, so it can't call [`Cpu::to_dyn`].
/// [`cpu_select!`] and [`#[cpu_multiversion]`] use this function, so they work in `const` code.
///
/// Only [`DynCpu`] needs `cpu`. It's taken for all types so that this can only be called
/// by code which already has one of these types.
///
/// [`#[cpu_multiversion]`]: macro@cpu_multiversion
#[expect(clippy::inline_always, reason = "folds to a constant, except for `DynCpu`")]
#[inline(always)]
pub const fn to_dyn<C: Cpu>(cpu: C) -> DynCpu {
match C::DYN_CPU {
Some(dyn_cpu) => dyn_cpu,
// SAFETY: `DYN_CPU` is `None` only for `DynCpu`, and for `Generic` when it's uninhabited.
// No value of an uninhabited type exists, so `cpu` must be a `DynCpu`.
None => unsafe { mem::transmute_copy::<C, DynCpu>(&cpu) },
}
}
/// Enum representing a CPU feature set.
///
/// Used for runtime feature detection.
@@ -147,6 +126,27 @@ impl CpuPrivate for DynCpu {
const DYN_CPU: Option<DynCpu> = None;
}
/// Get the [`DynCpu`] for a type implementing [`Cpu`].
///
/// Same as [`Cpu::to_dyn`], but this works in `const` code too.
/// A `const fn` can't call a trait method on a generic type, so it can't call [`Cpu::to_dyn`].
/// [`cpu_select!`] and [`#[cpu_multiversion]`] use this function, so they work in `const` code.
///
/// Only [`DynCpu`] needs `cpu`. It's taken for all types so that this can only be called
/// by code which already has one of these types.
///
/// [`#[cpu_multiversion]`]: macro@cpu_multiversion
#[expect(clippy::inline_always, reason = "folds to a constant, except for `DynCpu`")]
#[inline(always)]
pub const fn to_dyn<C: Cpu>(cpu: C) -> DynCpu {
match C::DYN_CPU {
Some(dyn_cpu) => dyn_cpu,
// SAFETY: `DYN_CPU` is `None` only for `DynCpu`, and for `Generic` when it's uninhabited.
// No value of an uninhabited type exists, so `cpu` must be a `DynCpu`.
None => unsafe { mem::transmute_copy::<C, DynCpu>(&cpu) },
}
}
/// Generic implementation.
mod generic {
use super::*;