mirror of
https://github.com/oxc-project/oxc.git
synced 2026-11-04 10:29:58 +00:00
feat(transformer_conformance): skip some tests that are known to fail (#3293)
I don't think we need to be completely consistent with Babel's output. Because Babel's output doesn't always make sense.
This commit is contained in:
Dunqing authored and 
GitHub committed
1 parent
b9d69ad665
commit
8ff1ffba74
4 files changed
+108
-90
No files matched your search
@@ -1,6 +1,6 @@
|
||||
commit: 4bd1b2c2
|
||||
|
||||
Passed: 310/362
|
||||
Passed: 310/351
|
||||
|
||||
# All Passed:
|
||||
* babel-preset-react
|
||||
@@ -16,26 +16,18 @@ Passed: 310/362
|
||||
* spec/newableArrowFunction-default/input.js
|
||||
* spec/newableArrowFunction-vs-spec-false/input.js
|
||||
|
||||
# babel-preset-typescript (7/16)
|
||||
# babel-preset-typescript (7/10)
|
||||
* node-extensions/import-in-cts/input.cts
|
||||
* node-extensions/type-assertion-in-cts/input.cts
|
||||
* node-extensions/type-assertion-in-mts/input.mts
|
||||
* node-extensions/type-param-arrow-in-cts/input.mts
|
||||
* node-extensions/type-param-arrow-in-mts/input.mts
|
||||
* node-extensions/with-in-mts/input.mts
|
||||
* opts/allowDeclareFields/input.ts
|
||||
* opts/optimizeConstEnums/input.ts
|
||||
* opts/rewriteImportExtensions/input.ts
|
||||
|
||||
# babel-plugin-transform-typescript (123/156)
|
||||
# babel-plugin-transform-typescript (123/154)
|
||||
* enum/mix-references/input.ts
|
||||
* enum/scoped/input.ts
|
||||
* enum/ts5.0-const-foldable/input.ts
|
||||
* exports/declared-types/input.ts
|
||||
* exports/export-type-star-from/input.ts
|
||||
* imports/enum-value/input.ts
|
||||
* imports/type-only-export-specifier-2/input.ts
|
||||
* namespace/canonical/input.ts
|
||||
* namespace/contentious-names/input.ts
|
||||
* namespace/empty-removed/input.ts
|
||||
* namespace/module-nested/input.ts
|
||||
@@ -62,12 +54,9 @@ Passed: 310/362
|
||||
* optimize-const-enums/merged-exported/input.ts
|
||||
* regression/15768/input.ts
|
||||
|
||||
# babel-plugin-transform-react-jsx (141/143)
|
||||
# babel-plugin-transform-react-jsx (141/142)
|
||||
* autoImport/complicated-scope-module/input.js
|
||||
* react-automatic/should-throw-when-filter-is-specified/input.js
|
||||
|
||||
# babel-plugin-transform-react-jsx-development (9/12)
|
||||
* cross-platform/self-inside-arrow/input.mjs
|
||||
* cross-platform/source-and-self-defined/input.js
|
||||
# babel-plugin-transform-react-jsx-development (9/10)
|
||||
* cross-platform/within-ts-module-block/input.ts
|
||||
|
||||
@@ -0,0 +1,91 @@
|
||||
pub(crate) const PLUGINS: &[&str] = &[
|
||||
// // ES2024
|
||||
// "babel-plugin-transform-unicode-sets-regex",
|
||||
// // ES2022
|
||||
// "babel-plugin-transform-class-properties",
|
||||
// "babel-plugin-transform-class-static-block",
|
||||
// "babel-plugin-transform-private-methods",
|
||||
// "babel-plugin-transform-private-property-in-object",
|
||||
// // [Syntax] "babel-plugin-transform-syntax-top-level-await",
|
||||
// // ES2021
|
||||
// "babel-plugin-transform-logical-assignment-operators",
|
||||
// "babel-plugin-transform-numeric-separator",
|
||||
// // ES2020
|
||||
// "babel-plugin-transform-export-namespace-from",
|
||||
// "babel-plugin-transform-dynamic-import",
|
||||
// "babel-plugin-transform-nullish-coalescing-operator",
|
||||
// "babel-plugin-transform-optional-chaining",
|
||||
// // [Syntax] "babel-plugin-transform-syntax-bigint",
|
||||
// // [Syntax] "babel-plugin-transform-syntax-dynamic-import",
|
||||
// // [Syntax] "babel-plugin-transform-syntax-import-meta",
|
||||
// // ES2019
|
||||
// "babel-plugin-transform-optional-catch-binding",
|
||||
// "babel-plugin-transform-json-strings",
|
||||
// // ES2018
|
||||
// "babel-plugin-transform-async-generator-functions",
|
||||
// "babel-plugin-transform-object-rest-spread",
|
||||
// // [Regex] "babel-plugin-transform-unicode-property-regex",
|
||||
// "babel-plugin-transform-dotall-regex",
|
||||
// // [Regex] "babel-plugin-transform-named-capturing-groups-regex",
|
||||
// // ES2017
|
||||
// "babel-plugin-transform-async-to-generator",
|
||||
// // ES2016
|
||||
// "babel-plugin-transform-exponentiation-operator",
|
||||
// // ES2015
|
||||
"babel-plugin-transform-arrow-functions",
|
||||
// "babel-plugin-transform-function-name",
|
||||
// "babel-plugin-transform-shorthand-properties",
|
||||
// "babel-plugin-transform-sticky-regex",
|
||||
// "babel-plugin-transform-unicode-regex",
|
||||
// "babel-plugin-transform-template-literals",
|
||||
// "babel-plugin-transform-duplicate-keys",
|
||||
// "babel-plugin-transform-instanceof",
|
||||
// "babel-plugin-transform-new-target",
|
||||
// // ES3
|
||||
// "babel-plugin-transform-property-literals",
|
||||
// TypeScript
|
||||
"babel-preset-typescript",
|
||||
"babel-plugin-transform-typescript",
|
||||
// React
|
||||
"babel-preset-react",
|
||||
"babel-plugin-transform-react-jsx",
|
||||
"babel-plugin-transform-react-display-name",
|
||||
"babel-plugin-transform-react-jsx-self",
|
||||
"babel-plugin-transform-react-jsx-source",
|
||||
"babel-plugin-transform-react-jsx-development",
|
||||
// // Proposal
|
||||
// "babel-plugin-proposal-decorators",
|
||||
];
|
||||
|
||||
pub(crate) const PLUGINS_NOT_SUPPORTED_YET: &[&str] = &[
|
||||
"proposal-decorators",
|
||||
"transform-class-properties",
|
||||
"transform-classes",
|
||||
"transform-destructuring",
|
||||
"transform-modules-commonjs",
|
||||
"transform-object-rest-spread",
|
||||
"transform-optional-chaining",
|
||||
"transform-parameters",
|
||||
"transform-private-methods",
|
||||
"transform-property-literals",
|
||||
"transform-react-constant-elements",
|
||||
];
|
||||
|
||||
pub(crate) const SKIP_TESTS: &[&str] = &[
|
||||
// Shouldn't report in transformer
|
||||
"typescript/test/fixtures/node-extensions/type-assertion-in-cts/input.cts",
|
||||
"typescript/test/fixtures/node-extensions/type-assertion-in-mts/input.mts",
|
||||
"typescript/test/fixtures/node-extensions/type-param-arrow-in-cts/input.mts",
|
||||
"typescript/test/fixtures/node-extensions/type-param-arrow-in-mts/input.mts",
|
||||
"typescript/test/fixtures/node-extensions/with-in-mts/input.mts",
|
||||
// Report error for deprecate option or oxc doesn’t follow error message
|
||||
"typescript/test/fixtures/opts/allowDeclareFields/input.ts",
|
||||
"react-jsx/test/fixtures/react-automatic/should-throw-when-filter-is-specified/input.js",
|
||||
"react-jsx-development/test/fixtures/cross-platform/source-and-self-defined/input.js",
|
||||
// Not standard JavaScript or TypeScript syntax
|
||||
"typescript/test/fixtures/exports/export-type-star-from/input.ts",
|
||||
// The output is valid and semantically correct
|
||||
// but does not match Babel's expected output
|
||||
"typescript/test/fixtures/namespace/canonical/input.ts",
|
||||
"react-jsx-development/test/fixtures/cross-platform/self-inside-arrow/input.mjs",
|
||||
];
|
||||
@@ -1,9 +1,11 @@
|
||||
mod constants;
|
||||
use std::{
|
||||
fs,
|
||||
path::{Path, PathBuf},
|
||||
process::Command,
|
||||
};
|
||||
|
||||
use constants::PLUGINS;
|
||||
use indexmap::IndexMap;
|
||||
use test_case::TestCaseKind;
|
||||
use walkdir::WalkDir;
|
||||
@@ -50,79 +52,6 @@ fn fixture_root() -> PathBuf {
|
||||
snap_root().join("fixtures")
|
||||
}
|
||||
|
||||
const PLUGINS: &[&str] = &[
|
||||
// // ES2024
|
||||
// "babel-plugin-transform-unicode-sets-regex",
|
||||
// // ES2022
|
||||
// "babel-plugin-transform-class-properties",
|
||||
// "babel-plugin-transform-class-static-block",
|
||||
// "babel-plugin-transform-private-methods",
|
||||
// "babel-plugin-transform-private-property-in-object",
|
||||
// // [Syntax] "babel-plugin-transform-syntax-top-level-await",
|
||||
// // ES2021
|
||||
// "babel-plugin-transform-logical-assignment-operators",
|
||||
// "babel-plugin-transform-numeric-separator",
|
||||
// // ES2020
|
||||
// "babel-plugin-transform-export-namespace-from",
|
||||
// "babel-plugin-transform-dynamic-import",
|
||||
// "babel-plugin-transform-nullish-coalescing-operator",
|
||||
// "babel-plugin-transform-optional-chaining",
|
||||
// // [Syntax] "babel-plugin-transform-syntax-bigint",
|
||||
// // [Syntax] "babel-plugin-transform-syntax-dynamic-import",
|
||||
// // [Syntax] "babel-plugin-transform-syntax-import-meta",
|
||||
// // ES2019
|
||||
// "babel-plugin-transform-optional-catch-binding",
|
||||
// "babel-plugin-transform-json-strings",
|
||||
// // ES2018
|
||||
// "babel-plugin-transform-async-generator-functions",
|
||||
// "babel-plugin-transform-object-rest-spread",
|
||||
// // [Regex] "babel-plugin-transform-unicode-property-regex",
|
||||
// "babel-plugin-transform-dotall-regex",
|
||||
// // [Regex] "babel-plugin-transform-named-capturing-groups-regex",
|
||||
// // ES2017
|
||||
// "babel-plugin-transform-async-to-generator",
|
||||
// // ES2016
|
||||
// "babel-plugin-transform-exponentiation-operator",
|
||||
// // ES2015
|
||||
"babel-plugin-transform-arrow-functions",
|
||||
// "babel-plugin-transform-function-name",
|
||||
// "babel-plugin-transform-shorthand-properties",
|
||||
// "babel-plugin-transform-sticky-regex",
|
||||
// "babel-plugin-transform-unicode-regex",
|
||||
// "babel-plugin-transform-template-literals",
|
||||
// "babel-plugin-transform-duplicate-keys",
|
||||
// "babel-plugin-transform-instanceof",
|
||||
// "babel-plugin-transform-new-target",
|
||||
// // ES3
|
||||
// "babel-plugin-transform-property-literals",
|
||||
// TypeScript
|
||||
"babel-preset-typescript",
|
||||
"babel-plugin-transform-typescript",
|
||||
// React
|
||||
"babel-preset-react",
|
||||
"babel-plugin-transform-react-jsx",
|
||||
"babel-plugin-transform-react-display-name",
|
||||
"babel-plugin-transform-react-jsx-self",
|
||||
"babel-plugin-transform-react-jsx-source",
|
||||
"babel-plugin-transform-react-jsx-development",
|
||||
// // Proposal
|
||||
// "babel-plugin-proposal-decorators",
|
||||
];
|
||||
|
||||
pub(crate) const PLUGINS_NOT_SUPPORTED_YET: &[&str] = &[
|
||||
"proposal-decorators",
|
||||
"transform-class-properties",
|
||||
"transform-classes",
|
||||
"transform-destructuring",
|
||||
"transform-modules-commonjs",
|
||||
"transform-object-rest-spread",
|
||||
"transform-optional-chaining",
|
||||
"transform-parameters",
|
||||
"transform-private-methods",
|
||||
"transform-property-literals",
|
||||
"transform-react-constant-elements",
|
||||
];
|
||||
|
||||
const CONFORMANCE_SNAPSHOT: &str = "babel.snap.md";
|
||||
const OXC_CONFORMANCE_SNAPSHOT: &str = "oxc.snap.md";
|
||||
const EXEC_SNAPSHOT: &str = "babel_exec.snap.md";
|
||||
|
||||
@@ -16,7 +16,10 @@ use oxc_transformer::{
|
||||
ES2015Options, ReactOptions, TransformOptions, Transformer, TypeScriptOptions,
|
||||
};
|
||||
|
||||
use crate::{fixture_root, packages_root, TestRunnerEnv, PLUGINS_NOT_SUPPORTED_YET};
|
||||
use crate::{
|
||||
constants::{PLUGINS_NOT_SUPPORTED_YET, SKIP_TESTS},
|
||||
fixture_root, packages_root, TestRunnerEnv,
|
||||
};
|
||||
|
||||
#[derive(Debug)]
|
||||
pub enum TestCaseKind {
|
||||
@@ -184,6 +187,12 @@ pub trait TestCase {
|
||||
return true;
|
||||
}
|
||||
|
||||
// Skip tests that are known to fail
|
||||
let full_path = self.path().to_string_lossy();
|
||||
if SKIP_TESTS.iter().any(|path| full_path.ends_with(path)) {
|
||||
return true;
|
||||
}
|
||||
|
||||
false
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user