mirror of
https://github.com/oxc-project/oxc.git
synced 2026-11-04 10:29:58 +00:00
fix(linter/unicorn): report on optional in require-number-to-fixed-digits-argument rule (#21207)
fixes commented out test with optional in `unicorn/require-number-to-fixed-digits-argument`
This commit is contained in:
1 parent
06e72c204e
commit
f21d3aa8d0
2 files changed
+14
-2
No files matched your search
@@ -57,7 +57,7 @@ impl Rule for RequireNumberToFixedDigitsArgument {
|
||||
return;
|
||||
}
|
||||
|
||||
if member.optional() || member.is_computed() {
|
||||
if member.is_computed() {
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -108,7 +108,7 @@ fn test() {
|
||||
|
||||
let fail = vec![
|
||||
"const string = number.toFixed();",
|
||||
// r#"const string = number?.toFixed() ?? "";"#,
|
||||
r#"const string = number?.toFixed() ?? "";"#,
|
||||
"const string = number.toFixed( /* comment */ );",
|
||||
"Number(1).toFixed()",
|
||||
"const bigNumber = new BigNumber(1); const string = bigNumber.toFixed();",
|
||||
@@ -116,6 +116,10 @@ fn test() {
|
||||
|
||||
let fix = vec![
|
||||
("const string = number.toFixed();", "const string = number.toFixed(0);"),
|
||||
(
|
||||
r#"const string = number?.toFixed() ?? "";"#,
|
||||
r#"const string = number?.toFixed(0) ?? "";"#,
|
||||
),
|
||||
(
|
||||
"const string = number.toFixed( /* comment */ );",
|
||||
"const string = number.toFixed( /* comment */ 0);",
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
---
|
||||
source: crates/oxc_linter/src/tester.rs
|
||||
assertion_line: 444
|
||||
---
|
||||
|
||||
⚠ eslint-plugin-unicorn(require-number-to-fixed-digits-argument): Number method .toFixed() should have an argument
|
||||
@@ -9,6 +10,13 @@ source: crates/oxc_linter/src/tester.rs
|
||||
╰────
|
||||
help: It's better to make it clear what the value of the digits argument is when calling Number#toFixed(), instead of relying on the default value of 0.
|
||||
|
||||
⚠ eslint-plugin-unicorn(require-number-to-fixed-digits-argument): Number method .toFixed() should have an argument
|
||||
╭─[require_number_to_fixed_digits_argument.tsx:1:31]
|
||||
1 │ const string = number?.toFixed() ?? "";
|
||||
· ──
|
||||
╰────
|
||||
help: It's better to make it clear what the value of the digits argument is when calling Number#toFixed(), instead of relying on the default value of 0.
|
||||
|
||||
⚠ eslint-plugin-unicorn(require-number-to-fixed-digits-argument): Number method .toFixed() should have an argument
|
||||
╭─[require_number_to_fixed_digits_argument.tsx:1:30]
|
||||
1 │ const string = number.toFixed( /* comment */ );
|
||||
|
||||
Reference in new issue
Block a user